-
Notifications
You must be signed in to change notification settings - Fork 56
feat(vault-jwt): allow specifying the vault jwt token directly #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
variable "vault_jwt_token" { | ||
type = string | ||
description = "The JWT token used for authentication with Vault." | ||
default = null | ||
sensitive = true | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an example use case on how you would provide that token to the module? Are you fetching it externally through some API or another provider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://gist.github.com/moo-im-a-cow/002e18137f5956893e610f85096e04e9#file-main-tf-L394-L422
this is how i'm currently generating the token, using another provider in the template
i'm doing this because i'd like to use a dedicated jwt token issued by coder for the workspace instead of passing through the token used to authenticate to coder
more info here: coder/coder#13127 (comment)
do you want the examples added to the commit in some way?
i'm unsure how documentation works here, but i'll do whatever is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want the examples added to the commit in some way?
i'm unsure how documentation works here, but i'll do whatever is needed
We usually add example Terraform snippets in the README.md
to guide users on possible ways the module can be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've now added an example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I would appreciate it if we could also add a vault policy that can use this new jwt token, scoped to workspace metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a vault expert at all. But as far as I understand the the workspace scoped secrets need to be pre created in vault. How would one do that.
In other words, I agree with use case to provide workspace only secrets access but is concerned if it makes the config difficult on the vault side. How would one provision these secrets? For what type of secrets this is most useful for.
Thanks.
variable "vault_jwt_token" { | ||
type = string | ||
description = "The JWT token used for authentication with Vault." | ||
default = null | ||
sensitive = true | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I would appreciate it if we could also add a vault policy that can use this new jwt token, scoped to workspace metadata.
Hi @moo-im-a-cow can you run |
this PR allows you to pass the desired jwt token to the vault-jwt module as a variable, for cases when you want to use a different jwt token to the one used to authenticate to vault
if not specified, it defaults to
data.coder_workspace_owner.me.oidc_access_token
.